Add method batch_update_list #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaucl
requested changes
Feb 13, 2024
|
Could you also add this endpoint to the test script? Even though the test workflow does not work atm :) |
already did |
method name changed to better reflect the method name used in the Bring android app `batchUpdateBringList`
|
renamed method to better reflect the method name used in the Bring Android app (batchUpdateBringList) |
|
@tr4nt0r What is currently not possible with the |
i think it's feature complete, it can do everything the app can do. It can do the same as |
Add support for item_uuid to `save_item`, `update_item`, `complete_item` and `remove_item`. Refactor methods to wrapper methods for batch_update_list for item_uuid support.
miaucl
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method batch_update_list.
This uses the same endpoint as the Bring App for manipulating the lists and supports adding, completing and removing items from a list. Using the items uuid as unique identifier is supported with this method, so differentiating items with the same name but with different specifications is possible. Changing an items name is also possible but should be avoided, as it has weird effects in the App.