Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Mermaid #60

Merged
merged 13 commits into from
May 18, 2023
Merged

Fixed Mermaid #60

merged 13 commits into from
May 18, 2023

Conversation

MIA-Deltat1995
Copy link
Contributor

@MIA-Deltat1995 MIA-Deltat1995 commented Mar 24, 2023 •
edited
Loading

Pull Request Type

  • Bugfix
  • Documentation content changes

Description

Removed custom component to support Mermaid and replaced with mdx-mermaid.

This PR fixes the render bug of Mermaid graphs (see Client Credentials Usage page), but it would be nice to support also the docusaurus theme:

mermaid

PR Checklist

  • The commit message follows our guidelines included in the CONTRIBUTING.md
  • All tests of Lint, cspell and check-content pass. (How to launch them?)
  • No sensible content has been committed

Other information

@MIA-Deltat1995 MIA-Deltat1995 requested a review from a team as a code owner March 24, 2023 11:12
@MIA-Deltat1995 MIA-Deltat1995 changed the base branch from feat/JMA-34-identities-management to main March 24, 2023 11:46
@MIA-Deltat1995 MIA-Deltat1995 marked this pull request as draft March 24, 2023 12:16
MIA-Deltat1995
MIA-Deltat1995 commented Apr 13, 2023
View reviewed changes
docusaurus.config.js Outdated Show resolved Hide resolved
@albertotessarotto albertotessarotto marked this pull request as ready for review May 16, 2023 14:40
fredmaggiowski
fredmaggiowski reviewed May 17, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@fredmaggiowski fredmaggiowski merged commit 51be013 into main May 18, 2023
@fredmaggiowski fredmaggiowski deleted the fixed-mermaid branch May 18, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredmaggiowski fredmaggiowski fredmaggiowski left review comments

@albertotessarotto albertotessarotto albertotessarotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MIA-Deltat1995 @fredmaggiowski @albertotessarotto