Skip to content

Commit

Permalink
Only annotate pyright errors in GitHub, not warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
Avasam committed Feb 28, 2024
1 parent 0a5a6ad commit c1374da
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ jobs:
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12']
steps:
- uses: actions/checkout@v3
- uses: jakebailey/pyright-action@v1
- uses: jakebailey/pyright-action@v2.2.0
with:
python-version: ${{ matrix.python-version }}
annotate: errors

2 changes: 1 addition & 1 deletion pyrightconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"typeCheckingMode": "basic",
// Target the oldest supported version in editors
"pythonVersion": "3.7",
// "pythonVersion": "3.7", // https://github.com/microsoft/pyright/issues/7330
// Keep it simple for now by allowing both mypy and pyright to use `type: ignore`
"enableTypeIgnoreComments": true,
// Exclude from scanning when running pyright
Expand Down

0 comments on commit c1374da

Please sign in to comment.