Skip to content

Commit

Permalink
Fix PATH issues
Browse files Browse the repository at this point in the history
  • Loading branch information
Avasam committed Jan 19, 2025
1 parent 5dc8fc2 commit b2acc3b
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 5 deletions.
15 changes: 11 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ jobs:
pip --version
pip install --upgrade setuptools>=74 wheel
- name: Fix user Scripts missing from PATH
if: matrix.architecture == 'x86'
run: |
# Work around https://github.com/actions/setup-python/issues/1005
$ScriptsPath = python -c "import sysconfig,os; print(sysconfig.get_path('scripts', f'{os.name}_user'))"
echo $ScriptsPath
Add-Content $env:GITHUB_PATH $ScriptsPath
- name: Build and install
run: pip install . -v --user

Expand All @@ -49,13 +57,12 @@ jobs:
- name: Generate PyWin32.chm help file
run: python AutoDuck/make.py

# Smokescreen test to validate it doesn't crash and dlls can be found
# Smokescreen test to validate postinstall doesn't crash, dlls can be found, and both pathless invocation methods work
- name: Run postinstall install/remove
run: |
$UserSite = "$(python -m site --user-site)"
cd "$UserSite/.."
python Scripts/pywin32_postinstall.py -install -destination "$UserSite"
python Scripts/pywin32_postinstall.py -remove -destination "$UserSite"
python -m win32.scripts.pywin32_postinstall -install -destination "$UserSite"
pywin32_postinstall -remove -destination "$UserSite"
- name: Run tests
# Run the tests directly from the source dir so support files (eg, .wav files etc)
Expand Down
5 changes: 4 additions & 1 deletion CHANGES.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Notable changes in recent builds.
Notable changes in recent builds.

Maintained by hand, so what's "notable" is subjective! Contributors are
encouraged to add entries for their work.
Expand All @@ -14,6 +14,9 @@ https://mhammond.github.io/pywin32_installers.html.
Coming in build 309, as yet unreleased
--------------------------------------

* The postinstall script is now available as a console script. You can invoke it in one of two new methods:
1. `python -m pywin32_postinstall -install` (recommended)
2. `pywin32_postinstall -install` (shorter but you don't have control over which python environment is used)
* Removed param `hIcon` from `win32comext.shell.ShellExecuteEx`. It was unusable since Windows Vista (#2423, @Avasam)
* Fixed `nbios.NCBStruct` packing (#2406, @Avasam)
* Restored axdebug builds on Python 3.10 (#2416, @Avasam)
Expand Down

0 comments on commit b2acc3b

Please sign in to comment.