instcomp does not mangle component names with underscores #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stretch/gcc5.3.1 manages to miscompile emc/rs274/rs274ngc_pre.cc:strstore
New version of instcomp does not mangle component names with underscores in them.
Check example configs comply
Edited last remaining config file to use component name underscore incorrectly
Many configs already named the component to have the underscore,
to side step the name mangling effect by comp and keep loaded and
used component the same name.
The rest were edited last year when we worked on it previously
machinekoder
added a commit
to machinekoder/machinekit
that referenced
this pull request
Jun 30, 2017
f4481f561 Merge pull request machinekit#81 from machinekoder/machinekit-updates 17178e54f add jplan and ros proto definitions 6a2762863 fix gitignore 98f68e22b rtapi_message: fix whitespace cfc23327e specify proto2 syntax 50d5b91a7 merging updates from upstream Machinekit 30cb027e3 Merge pull request mhaberler#80 from machinekit/ArcEye-patch-1 394d3d897 Amend asciidoc.mustache a328a2478 Merge pull request mhaberler#79 from machinekoder/js-bundle-update 60f39299a Merge pull request mhaberler#78 from machinekoder/python-build-fix 95f6c564e update js bundles 2179c974f reorder Makefile commands correctly 5531e8cf1 Merge pull request mhaberler#77 from machinekoder/java-support 6c428b26f adding Java build add0bf491 Merge pull request mhaberler#75 from machinekoder/doc-build-fix 4b58961c0 fix docs build 8cb5b75ce Merge pull request mhaberler#74 from machinekoder/pypi2 dc0d32268 PyPI: update dependencies 6211ed296 Merge pull request mhaberler#73 from machinekoder/pypi 9b16d1f9e preparing for PyPi git-subtree-dir: src/machinetalk/proto git-subtree-split: f4481f561ac76a6976afad03f13c7b8e0f7af318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of instcomp does not mangle component names with underscores in them.
Check example configs comply
Edited last remaining config file to use component name underscore incorrectly
Many configs already named the component to have the underscore,
to side step the name mangling effect by comp and keep the loaded and the used
component name the same.
The rest were edited last year when we worked on it previously