-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor a parameter for SetCellUsing and SetPropertyUsing #213
base: master
Are you sure you want to change the base?
Conversation
andywu188
commented
Aug 26, 2022
- Solve the problem that SetCellUsing and SetPropertyUsing parameters are not named and ambiguous.
- Improved support for parameters that can perform multiple property value calculations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 94.29% 95.27% +0.97%
==========================================
Files 11 13 +2
Lines 1384 1417 +33
Branches 203 203
==========================================
+ Hits 1305 1350 +45
+ Misses 51 39 -12
Partials 28 28 ☔ View full report in Codecov by Sentry. |
Thanks. There are some uncovered lines still, though. |
already updated |
I recommend making the other SetCellUsing and SetPropertyUsing methods obsolete. |
Can you add this to the PR? |
already updated |