Makes BacNet properties configurable

metricq · Nov 7, 2024 · f9b143a · f9b143a
1 parent 1b20caa
commit f9b143a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/metricq_source_bacpypes/config_model.py b/metricq_source_bacpypes/config_model.py
@@ -66,6 +66,10 @@ class Device(BaseModel, **_model_config):
 class Source(BaseModel, extra="ignore", frozen=True):
     bacnetAddress: str
     """Address of the BacNet client used as source"""
+    bacnetIdentifier: int
+    """Identifier for the BacNet client used as source"""
+    bacnetName: str
+    """Name of the BacNet client used as source"""
     interval: PositiveFloat | PositiveInt | str | None = None
     """
     Default query interval in seconds.

diff --git a/metricq_source_bacpypes/source.py b/metricq_source_bacpypes/source.py
@@ -333,8 +333,8 @@ async def _on_config(
                 self.bacnet = None
 
         this_device = DeviceObject(
-            objectName="MetricQBacpypesSource",
-            objectIdentifier=7,
+            objectName=config.bacnetName,
+            objectIdentifier=config.bacnetIdentifier,
             vendorIdentifier=15,
             maxApduLengthAccepted=1476,  # was like that in ye olden scriptures
         )