bug: protoc updated version naming conventions #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmaxde
changed the title
devmaxde
force-pushed
the
fix_protoc_regex
branch
2 times, most recently
from
1485a07 to
a4173c2
Compare
This was
linked to
issues
Oct 1, 2024
devmaxde
force-pushed
the
fix_protoc_regex
branch
from
a4173c2 to
62523f7
Compare
eg. 3.27.1 --> 27.1 Fixed black formatting
devmaxde
force-pushed
the
fix_protoc_regex
branch
from
62523f7 to
c75792e
Compare
bmario
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request modifies the version parsing regex to handle cases where the major version is not specified. It will default to 3, because the value is reused later.
https://protobuf.dev/support/version-support/