Protobuf / clang-format fixes #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the config version of FindPackage. But we have to sue the module compatibiltiy, because the build commands of config version are totally different and undocumented. see protocolbuffers/protobuf#12637 (comment) see https://stackoverflow.com/a/56896032/620382
- remove duplicates - remove unsupported options - fix options that were previsouly bool and are now string - manual BraceWrapping to avoid breaking lambdas (that would be really bad for our callback-hell)
|
Ugh, our ubuntu build doesn't like it, it doesn't seem to have a |
For some reason there is a weird template instantiation that breaks with the lambda auto parameter.
bmario
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.