feat(combinator): displayExpression with prefix notation #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase, so the CI can run. |
floork
force-pushed
the
displayExpression
branch
from
2150da0 to
a02a981
Compare
bmario
requested changes
Jan 27, 2025
floork
force-pushed
the
displayExpression
branch
from
2c47091 to
5fab0d1
Compare
bmario
requested changes
Jan 28, 2025
| } | ||
| catch (std::runtime_error&) | ||
| { | ||
| Log::error("Failed to create the Display Expression"); |
There was a problem hiding this comment.
Please add context to the error message.
- what is the affected metric?
- what is the error message of the runtime error?
| { | ||
| metric.metadata["displayExpression"] = displayExpression(combined_expression); | ||
| } | ||
| catch (std::runtime_error&) |
There was a problem hiding this comment.
Suggested change
| catch (std::runtime_error&) | |
| catch (const std::runtime_error&) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shows the
displayExpressionin prefix notationfixes: #4