Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support legacy Elastic _bulk API clients which use Content-Type: application/json #606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

awesense-paul
Copy link

@awesense-paul awesense-paul commented Jan 7, 2025

Changes the Elastic bulk API parser to support requests with Content-Type: application/json, by sending all requests through the same code path. (the existing parser behaviour expected a single JSON object for application/json -- though that code path would error anyway -- which is still supported as the case where there is 1 object / no newlines).

Resolves #602

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2025

CLA assistant check
All committers have signed the CLA.

@lmangani
Copy link
Collaborator

lmangani commented Jan 7, 2025

@awesense-paul thanks for taking the time to submit this PR! We appreciate it 🎉
@akvlad this needs to be ported into the next major to make sure this behaviour is retained please 🙏

@awesense-paul
Copy link
Author

(sorry, it was not my intention to close the pull request -- I was only intending to rebase on latest master and GPG-sign my commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support legacy Elastic _bulk API clients which use Content-Type: application/json
3 participants