Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json serialization of sets as list #94

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Add json serialization of sets as list #94

merged 3 commits into from
Sep 26, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Sep 26, 2024 •
edited
Loading

Change Summary

Aerovaldb will serialize sets as lists.

Related issue number

Chat with Lewis

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added this to the m2024-10 milestone Sep 26, 2024
@thorbjoernl thorbjoernl self-assigned this Sep 26, 2024
@thorbjoernl thorbjoernl marked this pull request as ready for review September 26, 2024 13:30
lewisblake
lewisblake approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lewisblake lewisblake merged commit 4506bf1 into main Sep 26, 2024
5 checks passed
@lewisblake lewisblake deleted the add-set-serialization-support branch September 26, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewisblake lewisblake lewisblake approved these changes

Assignees

@thorbjoernl thorbjoernl

Labels
None yet
Projects
None yet
Milestone
m2024-10
Development

Successfully merging this pull request may close these issues.
2 participants
@thorbjoernl @lewisblake