Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache filtered endpoint #116

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Cache filtered endpoint #116

merged 7 commits into from
Jan 22, 2025

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jan 22, 2025 •
edited
Loading

Change Summary

Cache map endpoint (or really all filtered endpoints).

  • Filtered endpoints will respect the cache argument to getter function calls, and use cached results if cache=True.

Related issue number

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl changed the title Cache map endpoint Cache filtered endpoint Jan 22, 2025
@thorbjoernl thorbjoernl marked this pull request as ready for review January 22, 2025 13:29
@thorbjoernl thorbjoernl merged commit 88bb686 into main Jan 22, 2025
6 checks passed
@thorbjoernl thorbjoernl deleted the cache-map-endpoint branch January 22, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heikoklein heikoklein heikoklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thorbjoernl @heikoklein