-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance when requesting contours in combined files #111
Conversation
Benchmark: 79s->31s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please consider renaming some functions/classes to more commonly used ones, and remove strange # @override
comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks. Just some smaller comments.
src/aerovaldb/utils/typing.py
Outdated
@@ -0,0 +1,21 @@ | |||
import sys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename utils/typing.py
to compat/typing.py
since it is only a compatibility layer.
f324d45
to
814e296
Compare
Change Summary
SystemError: (11, 'Resource temporarily unavailable')
in tests #46 (comment))Related issue number
closes #110
Checklist