Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance when requesting contours in combined files #111

Merged
merged 12 commits into from
Jan 21, 2025

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jan 20, 2025

Change Summary

Related issue number

closes #110

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added this to the m2025-02 milestone Jan 20, 2025
@thorbjoernl thorbjoernl self-assigned this Jan 20, 2025
@thorbjoernl thorbjoernl marked this pull request as ready for review January 21, 2025 10:24
Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please consider renaming some functions/classes to more commonly used ones, and remove strange # @override comments

src/aerovaldb/jsondb/cache.py Outdated Show resolved Hide resolved
src/aerovaldb/jsondb/cache.py Outdated Show resolved Hide resolved
src/aerovaldb/jsondb/cache.py Outdated Show resolved Hide resolved
src/aerovaldb/jsondb/cache.py Outdated Show resolved Hide resolved
src/aerovaldb/jsondb/cache.py Show resolved Hide resolved
Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. Just some smaller comments.

src/aerovaldb/jsondb/cache.py Outdated Show resolved Hide resolved
@@ -0,0 +1,21 @@
import sys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename utils/typing.py to compat/typing.py since it is only a compatibility layer.

@thorbjoernl thorbjoernl force-pushed the fix-contour-performance-issues branch from f324d45 to 814e296 Compare January 21, 2025 13:15
@thorbjoernl thorbjoernl merged commit 519301d into main Jan 21, 2025
6 checks passed
@thorbjoernl thorbjoernl deleted the fix-contour-performance-issues branch January 21, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance issues with contour filtering
2 participants