Adjust wrapSubscription to handle invalid errors
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases the `subscriptionProto.error` function override defined in `wrapSubscription` can receive a falsey `err` parameter. When this happens an exception is thrown since the error function override isn't being very defensive. The changes in this commit skip error handling if the passed in error is invalid. Original issue: meteorhacks#247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the
subscriptionProto.errorfunction override defined inwrapSubscriptioncan receive a falseyerrparameter. When this happens an exception is thrown since the error function override isn't being very defensive. The changes in this commit skip error handling if the passed in error is invalid.I also replaced the deprecated calls to
Meteor.uuidwithuuidcalls from theuuidnpm package. This helped resolved most of the test failures. A few test failures remain (~4), but they're timing errors (some runs pass, some runs fail) so I left them as is.Original issue: meteorhacks#247