feat: update solana crates #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1.18.*` version + fmt and warnings fix
StanChe
reviewed
Aug 8, 2024
StanChe
reviewed
Aug 8, 2024
StanChe
reviewed
Aug 8, 2024
StanChe
reviewed
Aug 8, 2024
|
@danenbm Plz take a look on this PR, @RequescoS said that your are working currently on the same thing |
blockiosaurus
previously approved these changes
Aug 8, 2024
StanChe
reviewed
Aug 8, 2024
danenbm
approved these changes
Aug 8, 2024
danenbm
requested changes
Aug 8, 2024
danenbm
approved these changes
Aug 8, 2024
StanChe
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing special, justupdate Solana crates versions. This update is necessary for reduce dependency hell in Utility-Chain repo.Since we updated solana crates versions to
1.18.*, the definition of theGeyserPlugintrait has changed. The_is_reloadargument was added to theon_loadfunction. I added this argument and logged it. Also I fixed some fmt and warnings from Сargo.Also updated crates versions:
plerklefrom1.6.0to1.7.0plerkle_serializationfrom1.8.0to1.9.0plerkle_messengerfrom1.8.0to1.8.1TODO: We have a lot of warnings and errors on ci from
clippy, I didn't fix it because I'm not sure if it's my area of responsibility, but if I'm wrong please let me know and I'll fix it.Additional info about this
on_loadflag:solana-labs/solana#33674
solana-labs/solana#24871
solana-labs/solana#30352