Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds specific error message for pagination limit #36

Closed
wants to merge 1 commit into from
Closed

Adds specific error message for pagination limit #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion das_api/src/api/api_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ impl DasApi {
if let Some(limit) = limit {
// make config item
if *limit > 1000 {
return Err(DasApiError::PaginationError);
return Err(DasApiError::PaginationLimitError);
}
}

Expand Down
3 changes: 3 additions & 0 deletions das_api/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ pub enum DasApiError {
PaginationError,
#[error("Pagination Error. No Pagination Method Selected")]
PaginationEmptyError,
// TODO change `1000` to a dynamic parameter provided by a config
#[error("Pagination Error. Limit must be less than or equal to 1000.")]
PaginationLimitError,
#[error("Deserialization error: {0}")]
DeserializationError(#[from] serde_json::Error),
}
Expand Down