Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add download json_data task for token metdata extensions #231

Merged
merged 3 commits into from
Jan 14, 2025
Merged

add download json_data task for token metdata extensions #231

merged 3 commits into from
Jan 14, 2025

Conversation

Nagaprasadvr
Copy link
Collaborator

@Nagaprasadvr Nagaprasadvr commented Jan 7, 2025 •
edited
Loading

  • Run download_metdata_json background task to download json data from uri

kespinola
kespinola requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@kespinola kespinola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking to confirm metadata uri is always set and shouldn't be no-op unless metadata plugin is present.

program_transformers/src/token_extensions/mod.rs Outdated Show resolved Hide resolved
program_transformers/src/token_extensions/mod.rs Outdated Show resolved Hide resolved
@Nagaprasadvr Nagaprasadvr requested a review from kespinola January 7, 2025 08:15
@Nagaprasadvr Nagaprasadvr force-pushed the das-95-add-download_metadata_json-task-for-token-mints-with branch 3 times, most recently from 1a8c372 to dc23af7 Compare January 7, 2025 09:05
@kespinola kespinola mentioned this pull request Jan 7, 2025
Merged
2 tasks
@kespinola kespinola force-pushed the das-95-add-download_metadata_json-task-for-token-mints-with branch from dc23af7 to d85f831 Compare January 7, 2025 16:20
danenbm
danenbm approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kespinola kespinola merged commit e9fce97 into metaplex-foundation:main Jan 14, 2025
3 checks passed
@kespinola kespinola deleted the das-95-add-download_metadata_json-task-for-token-mints-with branch January 14, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danenbm danenbm danenbm approved these changes

@kespinola kespinola kespinola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nagaprasadvr @kespinola @danenbm