Remove duplicate results for same asset_ids in get_assets rpc method #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nagaprasadvr
requested changes
Dec 3, 2024
|
suggested improvments implemented @Nagaprasadvr |
AhzamAkhtar
commented
Dec 4, 2024
Nagaprasadvr
approved these changes
Dec 31, 2024
AhzamAkhtar
force-pushed
the
das-60-in-get-assets-remove-duplicate-results-for-same-asset-id
branch
from
dc2849f to
5032833
Compare
kespinola
force-pushed
the
das-60-in-get-assets-remove-duplicate-results-for-same-asset-id
branch
from
5032833 to
46801b5
Compare
kespinola
approved these changes
Jan 7, 2025
Users can pass in duplicate asset ids when calling getAssets. This remove the duplicates before processing the request. Co-authored-by: Kyle Espinola <[email protected]>
kespinola
force-pushed
the
das-60-in-get-assets-remove-duplicate-results-for-same-asset-id
branch
from
46801b5 to
45f7219
Compare
kespinola
deleted the
das-60-in-get-assets-remove-duplicate-results-for-same-asset-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In getAssets rpc method , a user can provide multiple same asset_id to search for, and the api will give that many duplicated results, instead we can return a single result.
Tasks