Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingester: fix ctrl-c handler #140

Closed
wants to merge 3 commits into from

Conversation

fanatid
Copy link
Collaborator

@fanatid fanatid commented Nov 20, 2023

The current Ctrl-C handler doesn't make any sense, everything works the same even if we do not have this handler.
Instead of returning JoinHandle from the functions I made them async and used try_join_all with signals (sigterm ,sigint). Right now all tasks actually never return Err but we can change it in the future and signals handler still would work correctly.

fmt, clippy (+rust update) can be moved to another PR, if required

@fanatid
Copy link
Collaborator Author

fanatid commented Nov 20, 2023

Need to be updated after #141
Not actuall with nft_ingester2.

@fanatid fanatid closed this Nov 27, 2023
@fanatid fanatid deleted the ctrl-c-fix branch November 27, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant