fix: creators sql #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanChe
reviewed
Jan 8, 2024
Comment on lines
326
to
327
| .map_err(|e| DbErr::Custom(e.to_string())) | ||
| .unwrap_or(serde_json::Value::Null), |
There was a problem hiding this comment.
We don't need to map and then unwrap or, we should do either one or another. If metadata is an invalid json - we either error (and map_err) or just return Null. Not sure, what the spec requires of us.
There was a problem hiding this comment.
Thanks! I took away these changes, because they have already been implemented in your PR.
StanChe
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.