Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intuitionize ZZring #4697

Merged
merged 41 commits into from
Mar 9, 2025
Merged

Intuitionize ZZring #4697

merged 41 commits into from
Mar 9, 2025

Conversation

jkingdon
Copy link
Contributor

@jkingdon jkingdon commented Mar 8, 2025

This is the section "Ring of integers"

Includes bringing over one rename from set.mm and a few theorems from other sections.

Most theorems require few changes. Others are noted in mmil.html as not yet intuitionized.

jkingdon added 30 commits March 7, 2025 16:42
Stated as in set.mm.  The proof needs some intuitionizing but is
basically the set.mm proof.  Adjust comment for how we expect to use it
in iset.mm.
This was already renamed in set.mm.
This is the section header, syntax and df-zring .  Copied without change
from set.mm.
Stated as in set.mm.  The proof needs a little bit of intuitionizing but
is basically the set.mm proof.
Stated as in set.mm.  The proof needs a little intuitionizing but is
basically the set.mm proof.
Don't refer to a theorem we don't yet have in iset.mm
Stated as in set.mm.  The proof needs a little intuitionizing but is
basically the set.mm proof.
Stated as in set.mm.  The proof needs some intuitionizing but is
basically the set.mm proof.
Stated as in set.mm.  The proof is direct from ress0g .  The commment is
the same as set.mm except for a reference to two theorems which iset.mm
doesn't have yet.
Stated as in set.mm.  The intuitionizing of the proof consists of
renaming one theorem reference but the proof is otherwise the set.mm
proof.
jkingdon added 10 commits March 7, 2025 16:42
Stated as in set.mm.  The proof needs a little intuitionizing but is
basically the set.mm proof.
This is zringlpirlem1 , zringlpirlem2 , zringlpirlem3 , zringlpir ,
zringndrg , and zringcyg .
Stated as in set.mm.  The proof needs a small tweak (at least as iset.mm
stands currently) but is basically the set.mm proof.
This is prmirredlem , dfprm2 , and prmirred
iset.mm Outdated
Comment on lines 153334 to 153337
$( The multiplication group of the ring of integers is the restriction of the
multiplication group of the complex numbers to the integers. (Contributed
by AV, 15-Jun-2019.) $)
zringmpg $p |- ( ( mulGrp ` CCfld ) |`s ZZ ) = ( mulGrp ` ZZring ) $=
Copy link
Contributor

@icecream17 icecream17 Mar 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A carryover typo (appears twice:)
multiplication group --> multiplicative group

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in both set.mm and iset.mm.

Change multiplication group to multiplicative group
@jkingdon jkingdon merged commit b0c200d into metamath:develop Mar 9, 2025
10 checks passed
@jkingdon jkingdon deleted the zring branch March 9, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants