-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intuitionize ZZring #4697
Merged
Merged
Intuitionize ZZring #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stated as in set.mm. The proof needs some intuitionizing but is basically the set.mm proof. Adjust comment for how we expect to use it in iset.mm.
This was already renamed in set.mm.
This is the section header, syntax and df-zring . Copied without change from set.mm.
Stated as in set.mm. The proof needs a little bit of intuitionizing but is basically the set.mm proof.
Stated as in set.mm. The proof needs a little intuitionizing but is basically the set.mm proof.
Don't refer to a theorem we don't yet have in iset.mm
Stated as in set.mm. The proof needs a little intuitionizing but is basically the set.mm proof.
Stated as in set.mm. The proof needs some intuitionizing but is basically the set.mm proof.
Stated as in set.mm. The proof is direct from ress0g . The commment is the same as set.mm except for a reference to two theorems which iset.mm doesn't have yet.
Stated as in set.mm. The intuitionizing of the proof consists of renaming one theorem reference but the proof is otherwise the set.mm proof.
Stated as in set.mm. The proof needs a little intuitionizing but is basically the set.mm proof.
This is zringlpirlem1 , zringlpirlem2 , zringlpirlem3 , zringlpir , zringndrg , and zringcyg .
Stated as in set.mm. The proof needs a small tweak (at least as iset.mm stands currently) but is basically the set.mm proof.
This is prmirredlem , dfprm2 , and prmirred
icecream17
approved these changes
Mar 8, 2025
iset.mm
Outdated
Comment on lines
153334
to
153337
$( The multiplication group of the ring of integers is the restriction of the | ||
multiplication group of the complex numbers to the integers. (Contributed | ||
by AV, 15-Jun-2019.) $) | ||
zringmpg $p |- ( ( mulGrp ` CCfld ) |`s ZZ ) = ( mulGrp ` ZZring ) $= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A carryover typo (appears twice:)
multiplication group --> multiplicative group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in both set.mm and iset.mm.
Change multiplication group to multiplicative group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the section "Ring of integers"
Includes bringing over one rename from set.mm and a few theorems from other sections.
Most theorems require few changes. Others are noted in mmil.html as not yet intuitionized.