-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace AlgNb
by IntgRing
from @digama0 's mathbox
#4632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icecream17
approved these changes
Feb 6, 2025
avekens
reviewed
Feb 7, 2025
avekens
reviewed
Feb 7, 2025
avekens
reviewed
Feb 7, 2025
avekens
reviewed
Feb 7, 2025
avekens
reviewed
Feb 7, 2025
avekens
approved these changes
Feb 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, everything is fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4578, this replaces
AlgNb
(algebraic numbers, defined by taking roots of nonzero polynomials) withIntgRing
(integral elements of a ring, defined by taking roots of monic polynomials).The new definition is more general, and as shown in
irngnzply1
, for fields, this is the same.The definition
df-irng
of elements of a ring integral over a subring is moved from @digama0's mathbox into mine, but I did not updatechanges-set.txt
as no theorem is moved. No theorem was previously developped based on this definition, I've added a few basic ones.This is one (very small) step towards solving #4246.
PS. I've fixed a small mistake in @digama0's definition (the
( r evalSub1 s )
was missing in( ( r evalSub1 s ) ` f )
), so I've added a "Revised by" in the definition's comment.