Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AlgNb by IntgRing from @digama0 's mathbox #4632

Merged
merged 4 commits into from
Feb 8, 2025

Conversation

tirix
Copy link
Contributor

@tirix tirix commented Feb 5, 2025

As discussed in #4578, this replaces AlgNb (algebraic numbers, defined by taking roots of nonzero polynomials) with IntgRing (integral elements of a ring, defined by taking roots of monic polynomials).

The new definition is more general, and as shown in irngnzply1, for fields, this is the same.

The definition df-irng of elements of a ring integral over a subring is moved from @digama0's mathbox into mine, but I did not update changes-set.txt as no theorem is moved. No theorem was previously developped based on this definition, I've added a few basic ones.

This is one (very small) step towards solving #4246.

PS. I've fixed a small mistake in @digama0's definition (the ( r evalSub1 s ) was missing in ( ( r evalSub1 s ) ` f )), so I've added a "Revised by" in the definition's comment.

set.mm Show resolved Hide resolved
set.mm Outdated Show resolved Hide resolved
set.mm Show resolved Hide resolved
set.mm Show resolved Hide resolved
set.mm Show resolved Hide resolved
set.mm Show resolved Hide resolved
set.mm Show resolved Hide resolved
@tirix tirix requested a review from avekens February 7, 2025 23:47
Copy link
Contributor

@avekens avekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, everything is fine now.

@tirix tirix merged commit c800cbc into metamath:develop Feb 8, 2025
10 checks passed
@tirix tirix deleted the constr branch February 8, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants