Unification of terms "ring unit" resp. "multiplicative identity" #4584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #4512, we have several different names for
1r
already at the beginning of section "Ring unit". With this PR, these differences should be levelled out.As proposed (and decided in principle) in issue #4512,
1r
should be called "multiplicative identity" or "(ring) unity" or "unity element" uniformly in (i)set.mm.An overview over the terms used in literature, and a discussion about the ambiguity of the term "unit" in the context of rings, is contained in the header comment of the section "Ring unit", which is changed to "Ring unity (multiplicative identity)" (see first commit).
In the following commits, the comments in set.mm are revised. I will do the same with iset.mm after this PR is accepted and merged (to avoid the effort to modify two files simultaneously if there are review remarks).
Here the details (provided in separate commits):