-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save ax-riotaBAD in glbconN #4528
Conversation
add discouraged tags to direct consequences of ax-riotaBAD 1218 -> 1154 (-64) dependents on ax-riotaBAD no $j usage since ax-riotaBAD will be deleted extra: 'autominimize' subsym1 (it would be automatic but nsb was changed to closed form; no tag or old)
no tags Co-authored-by: GinoGiotto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a change in NM's mathbox in a section labelled "Legacy theorems using obsolete axioms". What is the long-term intention of this pull request?
The modification of glbconN is ok. The proof is 3 lines shorter, and, by the way, does not depend on ax-un any more.
I checked your proof out and viewed it with gen-html: This theorem was proved from axioms: ax-mp ax-1 ax-2 ax-3 ax-gen ax-4 ax-5 ax-6 ax-7 ax-8 ax-9 ax-10 ax-11 ax-12 ax-ext ax-rep ax-sep ax-nul ax-pow ax-pr, and compare this to glbconN
According to the comment of https://us.metamath.org/mpeuni/ax-riotaBAD.html it and its direct consequences will be deleted https://us.metamath.org/mpeuni/df-aiota.html does a similar thing to ax-riotaBAD. I think all direct consequences of ax-riotaBAD have corresponding consequences for df-aiota. So not much information is lost. |
The point here is that you modify a foreign mathbox. In my opinion we should not allow that on a regular basis. Normally you either get the consent of the mathbox owner, or develop the theory by copying the material to your mathbox. Obviously Norm's mathbox is now abandonded, so we should find a way to get along with it. I support your moderate changes, but would like to hear other opinions, too. Maybe we can find rules to handle mathboxes where the owner hasn't shown up for some time, say 3 years or so. To avoid having garbage around nobody cares about any more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fully support this PR and the plan of deleting ax-riotaBAD. The comment itself makes it very clear that it is obsolete and should be removed.
Imo keeping old inconsistent material is not a good look, and we should encourage people to keep the database tight. I don't know about a general rule for changing abandoned mathboxes, but the lack of such rule should not be an obstacle to make positive changes such as this one.
I opened an issue #4541 to collect opinions on this matter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #4541 @avekens mentioned how the discouraged tags for ax-riotaBAD and its direct consequences are unnecessary, since the theorems are in a mathbox and won't be used. If there are no objections to this I'll change the pr accordingly tomorrow. I added the OLD version of glbconN to be on the safe side, but note that if ax-riotaBAD is eliminated, then its removal would also remove these OLD versions before a year is up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK now.
add discouraged tags to direct consequences of ax-riotaBAD
1218 -> 1154 (-64) dependents on ax-riotaBAD
no $j usage since ax-riotaBAD will be deleted
extra: 'autominimize' subsym1 (it would be automatic but nsb was changed to closed form; no tag or old)(shorter subsym1)Part of #4265