Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Service as a new target type #3022

Merged
merged 15 commits into from
Jan 23, 2025
Merged

Added Service as a new target type #3022

merged 15 commits into from
Jan 23, 2025

Conversation

Razz4780
Copy link
Contributor

@Razz4780 Razz4780 commented Jan 17, 2025 •
edited
Loading

@t4lz t4lz self-requested a review January 17, 2025 15:44
t4lz
t4lz approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@t4lz t4lz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of doc nitpicks etc.

mirrord/config/src/target.rs Outdated Show resolved Hide resolved
mirrord/config/src/target.rs Outdated Show resolved Hide resolved
mirrord/config/src/target.rs Outdated Show resolved Hide resolved
mirrord/config/src/target.rs Outdated Show resolved Hide resolved
mirrord/config/src/target.rs Outdated Show resolved Hide resolved
mirrord/config/src/target.rs Outdated Show resolved Hide resolved
mirrord/kube/src/api/runtime.rs Show resolved Hide resolved
mirrord/kube/src/api/runtime/cron_job.rs Show resolved Hide resolved
mirrord/kube/src/resolved.rs Outdated Show resolved Hide resolved
@Razz4780 Razz4780 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into metalbear-co:main with commit db91583 Jan 23, 2025
17 checks passed
@Razz4780 Razz4780 deleted the michals/mbe-657-add-support-for-service-in-operator branch January 23, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t4lz t4lz t4lz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Razz4780 @t4lz