-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespaces to mirrord ls
output
#3003
Add namespaces to mirrord ls
output
#3003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits here and there.
The main thing is, I would prefer to have kube interactions under the kube resource struct, as I find it's easier to think about (my thought process is usually: I want kube stuff, create this struct, now it offers me an api with exactly what I want ... Oh it doesn't have what I want? I add it to the struct). But we never talked about api design (not that I remember), maybe we should bring this up to the team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here you prefer present for all the docs. I feel trolled.
🧌
Issue #2999
Since
mirrord ls
currently returns a list of target paths, it was not possible to implement this without adding an extra env. IDEs will have to inspect mirrord binary version or try parsing the new format with fallback to the old one.Additionally, fixed
mirrord::port_forward
module visibility and removed some dead code.