-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPv6 support for traffic stealing #2976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4lz
force-pushed
the
ipv6
branch
3 times, most recently
from
December 31, 2024 07:49
752fd27
to
74fd7cf
Compare
t4lz
force-pushed
the
ipv6
branch
6 times, most recently
from
January 3, 2025 23:20
c95d1f7
to
9293af6
Compare
t4lz
force-pushed
the
ipv6
branch
7 times, most recently
from
January 8, 2025 16:36
933c349
to
a75467c
Compare
t4lz
changed the title
IPv6 support for traffic stealing - WIP
IPv6 support for traffic stealing
Jan 9, 2025
DmitryDodzin
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple nitpicks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2956
Add config flag to enable IPv6 support.
When enabled, mirrord will try to also steal IPv6 connections.
The plan is to enable it by default some day, so I made the behaviour of the agent when enabled what I think the future default behaviour should be: try to setup steeling for both IPv4 and IPv6. If at least one of them can be set up, that's fine, also if it's IPv4. Only fail if none of them could be set up.
Did not add any handling for a mesh + IPv6 case.
Added an E2E test.