Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 support for traffic stealing #2976

Merged
merged 72 commits into from
Jan 9, 2025
Merged

IPv6 support for traffic stealing #2976

merged 72 commits into from
Jan 9, 2025

Conversation

t4lz
Copy link
Member

@t4lz t4lz commented Dec 10, 2024

Closes #2956

Add config flag to enable IPv6 support.
When enabled, mirrord will try to also steal IPv6 connections.
The plan is to enable it by default some day, so I made the behaviour of the agent when enabled what I think the future default behaviour should be: try to setup steeling for both IPv4 and IPv6. If at least one of them can be set up, that's fine, also if it's IPv4. Only fail if none of them could be set up.

Did not add any handling for a mesh + IPv6 case.

Added an E2E test.

@t4lz t4lz changed the title IPv6 support - WIP IPv6 support for traffic stealing - WIP Dec 11, 2024
@t4lz t4lz force-pushed the ipv6 branch 3 times, most recently from 752fd27 to 74fd7cf Compare December 31, 2024 07:49
@t4lz t4lz force-pushed the ipv6 branch 6 times, most recently from c95d1f7 to 9293af6 Compare January 3, 2025 23:20
@t4lz t4lz force-pushed the ipv6 branch 7 times, most recently from 933c349 to a75467c Compare January 8, 2025 16:36
@t4lz t4lz marked this pull request as ready for review January 8, 2025 16:42
@t4lz t4lz changed the title IPv6 support for traffic stealing - WIP IPv6 support for traffic stealing Jan 9, 2025
Copy link
Member

@DmitryDodzin DmitryDodzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nitpicks

tests/src/utils.rs Outdated Show resolved Hide resolved
tests/src/traffic/steal.rs Outdated Show resolved Hide resolved
@t4lz t4lz enabled auto-merge January 9, 2025 14:49
@t4lz t4lz added this pull request to the merge queue Jan 9, 2025
Merged via the queue into metalbear-co:main with commit 81da4e4 Jan 9, 2025
17 checks passed
@t4lz t4lz deleted the ipv6 branch January 9, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support and test traffic stealing with IPv6
2 participants