Only add no bgp enforce-first-as on frr >= 10 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit91
reviewed
Jan 15, 2025
majst01
force-pushed
the
detect-frr-version
branch
3 times, most recently
from
0126a8a to
f730d2d
Compare
Gerrit91
approved these changes
Jan 15, 2025
majst01
force-pushed
the
detect-frr-version
branch
from
f730d2d to
0a83a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Older firewalls with frr < 10 would break if "no bgp enforce-first-as" is enabled. Make this configuration setting only for newer frr versions.
Depends on: