Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a diagram which illustrates the network setup #236

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

scoopex
Copy link
Contributor

@scoopex scoopex commented Dec 10, 2024

This diagram illustrates the networking setup
Tried to align design a bit to the metal-stack CI.

(i.e. https://docs.metal-stack.io/stable/overview/architecture/)

@scoopex scoopex requested a review from a team as a code owner December 10, 2024 07:04
@scoopex scoopex requested a review from Gerrit91 December 10, 2024 07:04
@metal-robot
Copy link
Contributor

metal-robot bot commented Dec 10, 2024

Thanks for contributing a pull request to the metal-stack docs!

A rendered preview of your changes will be available at: https://docs.metal-stack.io/previews/PR236/

@scoopex scoopex marked this pull request as draft December 10, 2024 07:05
@scoopex scoopex marked this pull request as ready for review December 10, 2024 07:39
@scoopex
Copy link
Contributor Author

scoopex commented Dec 10, 2024

Waiting for feedback about the design and the content/correctness of the diagram.

Signed-off-by: Marc Schöchlin <[email protected]>
@Gerrit91
Copy link
Contributor

Thanks for the contribution. I think the image is not fully correct, e.g. the tenant firewall should not be connected directly to an exit switch.

I will take a look into our training material for metal-stack and try to find an illustration of this because I think we have it. Then it will also have an identical style to most of the other figures that have made for the documentation repository.

@scoopex
Copy link
Contributor Author

scoopex commented Dec 11, 2024

Thanks for the contribution. I think the image is not fully correct, e.g. the tenant firewall should not be connected directly to an exit switch.

I will take a look into our training material for metal-stack and try to find an illustration of this because I think we have it. > Then it will also have an identical style to most of the other figures that have made for the documentation repository.

@Gerrit91 thanks for the feedback!
Can you give me a reference to the mentioned illustration in the training material (if that is a public resource) or add your diagram to the PR?

@Gerrit91
Copy link
Contributor

You cannot find them because the training material includes some confidential information. I removed the confidential stuff now and pushed the graphics into the illustrations branch: master...illustrations

You can integrate them into your PR, I was not able to push to your fork.

@scoopex
Copy link
Contributor Author

scoopex commented Dec 12, 2024

You cannot find them because the training material includes some confidential information. I removed the confidential stuff now and pushed the graphics into the illustrations branch: master...illustrations

You can integrate them into your PR, I was not able to push to your fork.

@Gerrit91 Integrated the proposed changes/additions.

@Gerrit91
Copy link
Contributor

Cool. If you need something else, let us know.

@Gerrit91 Gerrit91 merged commit fd9e485 into metal-stack:master Dec 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants