Fixes padding and behavior of hash links #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@wackerow this is great, thanks for fixing! |
jonathanprozzi
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The nav bar has hash links to sections of the page, but needed a little padding for it to go to the correct place.
Fix
scroll-padding-top: 6rem; scroll-behavior: smooth;toglobals.cssglobals.cssfile that was there was not being used, so cleared out everything else, replacing with just this one adjustment, then imported into_app.tsx@jonathanprozzi Didn't see an easy fix for this using Chakra but I'm still new to it, let me know if there is another way to do this.