PICARD-1685 : Add ~filesize variable

picard/file.py

@@ -89,6 +89,7 @@
     normpath,
     thread,
     tracknum_and_title_from_filename,
+    encode_filename,
 )
 from picard.util.filenaming import (
     get_available_filename,
@@ -132,7 +133,7 @@ class File(QtCore.QObject, Item):
 
     EXTENSIONS = []
 
-    FILE_INFO_TAGS = ('~bitrate', '~sample_rate', '~channels', '~bits_per_sample', '~format')
+    FILE_INFO_TAGS = ('~bitrate', '~sample_rate', '~channels', '~bits_per_sample', '~format', '~filesize')
 
     comparison_weights = {
         'title': 13,
@@ -760,6 +761,11 @@ def can_view_info(self):
         return True
 
     def _info(self, metadata, file):
+        try:
+            size = os.path.getsize(encode_filename(self.filename))
+            metadata['~filesize'] = size
+        except BaseException:
+            pass
         if hasattr(file.info, 'length'):
             metadata.length = int(file.info.length * 1000)
         if hasattr(file.info, 'bitrate') and file.info.bitrate:

picard/ui/infodialog.py

@@ -286,12 +286,10 @@ def format_file_info(file_):
     info.append((_("Filename:"), file_.filename))
     if '~format' in file_.orig_metadata:
         info.append((_("Format:"), file_.orig_metadata['~format']))
-    try:
-        size = os.path.getsize(encode_filename(file_.filename))
+    if '~filesize' in file_.orig_metadata:
+        size = file_.orig_metadata['~filesize']
         sizestr = "%s (%s)" % (bytes2human.decimal(size), bytes2human.binary(size))
         info.append((_("Size:"), sizestr))
-    except BaseException:
-        pass
     if file_.orig_metadata.length:
         info.append((_("Length:"), format_time(file_.orig_metadata.length)))
     if '~bitrate' in file_.orig_metadata:

picard/ui/itemviews.py

@@ -170,6 +170,7 @@ class MainPanel(QtWidgets.QSplitter):
         (N_("Catalog No."), 'catalognumber'),
         (N_("Barcode"), 'barcode'),
         (N_("Media"), 'media'),
+        (N_("Size"), '~filesize'),
         (N_("Genre"), 'genre'),
         (N_("Fingerprint status"), '~fingerprint'),
         (N_("Date"), 'date'),

test/formats/test_vorbis.py

@@ -208,6 +208,7 @@ class FLACTest(CommonVorbisTests.VorbisTestCase):
         '~channels': '2',
         '~sample_rate': '44100',
         '~format': 'FLAC',
+        '~filesize':'6546'
     }
     unexpected_info = ['~video']