PICARD-1685 : Add ~filesize variable

picard/file.py

@@ -89,6 +89,7 @@
     normpath,
     thread,
     tracknum_and_title_from_filename,
+    encode_filename,
 )
 from picard.util.filenaming import (
     get_available_filename,
@@ -132,7 +133,7 @@ class File(QtCore.QObject, Item):
 
     EXTENSIONS = []
 
-    FILE_INFO_TAGS = ('~bitrate', '~sample_rate', '~channels', '~bits_per_sample', '~format')
+    FILE_INFO_TAGS = ('~bitrate', '~sample_rate', '~channels', '~bits_per_sample', '~format', '~filesize')
 
     comparison_weights = {
         'title': 13,
@@ -760,6 +761,10 @@ def can_view_info(self):
         return True
 
     def _info(self, metadata, file):
+        try:
+            metadata['~filesize'] = os.path.getsize(encode_filename(self.filename))
+        except BaseException:
+            pass
         if hasattr(file.info, 'length'):
             metadata.length = int(file.info.length * 1000)
         if hasattr(file.info, 'bitrate') and file.info.bitrate:

picard/formats/wav.py

@@ -25,6 +25,7 @@
 
 
 from collections.abc import MutableMapping
+import os
 
 import mutagen
 
@@ -33,6 +34,7 @@
 from picard.file import File
 from picard.formats.id3 import NonCompatID3File
 from picard.metadata import Metadata
+from picard.util import encode_filename
 
 
 try:
@@ -235,6 +237,7 @@ def _load(self, filename):
             metadata['~sample_rate'] = f.getframerate()
             metadata.length = 1000 * f.getnframes() // f.getframerate()
             metadata['~format'] = self.NAME
+            metadata['~filesize'] = os.path.getsize(encode_filename(self.filename))
             self._add_path_to_metadata(metadata)
             return metadata
 

picard/ui/infodialog.py

@@ -33,7 +33,6 @@
     namedtuple,
 )
 from html import escape
-import os.path
 import re
 import traceback
 
@@ -286,12 +285,10 @@ def format_file_info(file_):
     info.append((_("Filename:"), file_.filename))
     if '~format' in file_.orig_metadata:
         info.append((_("Format:"), file_.orig_metadata['~format']))
-    try:
-        size = os.path.getsize(encode_filename(file_.filename))
+    if '~filesize' in file_.orig_metadata:
+        size = file_.orig_metadata['~filesize']
         sizestr = "%s (%s)" % (bytes2human.decimal(size), bytes2human.binary(size))
         info.append((_("Size:"), sizestr))
-    except BaseException:
-        pass
     if file_.orig_metadata.length:
         info.append((_("Length:"), format_time(file_.orig_metadata.length)))
     if '~bitrate' in file_.orig_metadata:

picard/ui/itemviews.py

@@ -170,6 +170,7 @@ class MainPanel(QtWidgets.QSplitter):
         (N_("Catalog No."), 'catalognumber'),
         (N_("Barcode"), 'barcode'),
         (N_("Media"), 'media'),
+        (N_("Size"), '~filesize'),
         (N_("Genre"), 'genre'),
         (N_("Fingerprint status"), '~fingerprint'),
         (N_("Date"), 'date'),

test/formats/test_aac.py

@@ -41,6 +41,7 @@ class AACTest(CommonTests.SimpleFormatsTestCase):
         '~channels': '2',
         '~sample_rate': '44100',
         '~bitrate': '123.824',
+        '~filesize': '1896',
     }
     unexpected_info = ['~video']
 
@@ -53,6 +54,7 @@ class AACWithAPETest(CommonApeTests.ApeTestCase):
         '~channels': '2',
         '~sample_rate': '44100',
         '~bitrate': '123.824',
+        '~filesize': '1974',
     }
     unexpected_info = ['~video']
 

test/formats/test_ac3.py

@@ -44,6 +44,7 @@ class AC3WithAPETest(CommonApeTests.ApeTestCase):
         '~bitrate': '192.0',
         '~sample_rate': '44100',
         '~channels': '2',
+        '~filesize': '2570',
     }
     unexpected_info = ['~video']
 
@@ -109,6 +110,7 @@ class EAC3Test(CommonTests.SimpleFormatsTestCase):
         'length': 107,
         '~sample_rate': '44100',
         '~channels': '2',
+        '~filesize': '2570',
     }
     unexpected_info = ['~video']
 

test/formats/test_apev2.py

@@ -172,6 +172,7 @@ class MonkeysAudioTest(CommonApeTests.ApeTestCase):
         '~channels': '2',
         '~sample_rate': '44100',
         '~bits_per_sample': '16',
+        '~filesize': '2496',
     }
     unexpected_info = ['~video']
 
@@ -183,6 +184,7 @@ class WavPackTest(CommonApeTests.ApeTestCase):
         'length': 82,
         '~channels': '2',
         '~sample_rate': '44100',
+        '~filesize': '2542',
     }
     unexpected_info = ['~video']
 
@@ -247,6 +249,7 @@ class MusepackSV7Test(CommonApeTests.ApeTestCase):
         'length': 91,
         '~channels': '2',
         '~sample_rate': '44100',
+        '~filesize': '1605',
     }
     unexpected_info = ['~video']
 
@@ -258,6 +261,7 @@ class MusepackSV8Test(CommonApeTests.ApeTestCase):
         'length': 82,
         '~channels': '2',
         '~sample_rate': '44100',
+        '~filesize': '1633',
     }
     unexpected_info = ['~video']
 
@@ -274,7 +278,8 @@ def setUp(self):
                 'length': 82,
                 '~channels': '2',
                 '~sample_rate': '44100',
-                '~bits_per_sample': '16'
+                '~bits_per_sample': '16',
+                '~filesize': '2144',
             }
 
 
@@ -285,6 +290,7 @@ class OptimFROGLosslessTest(CommonApeTests.ApeTestCase):
         'length': 0,
         '~channels': '2',
         '~sample_rate': '48000',
+        '~filesize': '181',
     }
     unexpected_info = ['~video']
 
@@ -300,6 +306,7 @@ class OptimFROGDUalStreamTest(CommonApeTests.ApeTestCase):
         'length': 0,
         '~channels': '2',
         '~sample_rate': '48000',
+        '~filesize': '181',
     }
     unexpected_info = ['~video']
 

test/formats/test_asf.py

@@ -105,6 +105,7 @@ class ASFTest(CommonAsfTests.AsfTestCase):
         '~channels': '2',
         '~sample_rate': '44100',
         '~bitrate': '128.0',
+        '~filesize': '4881',
     }
 
 
@@ -116,6 +117,7 @@ class WMATest(CommonAsfTests.AsfTestCase):
         '~channels': '2',
         '~sample_rate': '44100',
         '~bitrate': '64.0',
+        '~filesize': '8164',
     }
     unexpected_info = ['~video']
 
@@ -129,6 +131,7 @@ class WMVTest(CommonAsfTests.AsfTestCase):
         '~sample_rate': '44100',
         '~bitrate': '128.0',
         '~video': '1',
+        '~filesize': '8453',
     }
 
 

test/formats/test_id3.py

@@ -610,6 +610,7 @@ class MP3Test(CommonId3Tests.Id3TestCase):
         'length': 156,
         '~channels': '2',
         '~sample_rate': '44100',
+        '~filesize': '2888',
     }
     unexpected_info = ['~video']
 
@@ -641,6 +642,7 @@ class TTATest(CommonId3Tests.Id3TestCase):
     expected_info = {
         'length': 82,
         '~sample_rate': '44100',
+        '~filesize': '3464',
     }
     unexpected_info = ['~video']
 
@@ -654,6 +656,7 @@ class DSFTest(CommonId3Tests.Id3TestCase):
         '~sample_rate': '5644800',
         '~bitrate': '11289.6',
         '~bits_per_sample': '1',
+        '~filesize': '114022',
     }
     unexpected_info = ['~video']
 
@@ -668,6 +671,7 @@ class DSDIFFTest(CommonId3Tests.Id3TestCase):
             '~sample_rate': '5644800',
             '~bitrate': '11289.6',
             '~bits_per_sample': '1',
+            '~filesize': '15288',
         }
         unexpected_info = ['~video']
 
@@ -679,6 +683,7 @@ class DSDIFFDSTTest(CommonId3Tests.Id3TestCase):
             '~channels': '2',
             '~sample_rate': '5644800',
             '~bits_per_sample': '1',
+            '~filesize': '2214',
         }
         unexpected_info = ['~video']
 
@@ -691,6 +696,7 @@ class AIFFTest(CommonId3Tests.Id3TestCase):
         '~channels': '2',
         '~sample_rate': '44100',
         '~bitrate': '1411.2',
+        '~filesize': '15704',
     }
     unexpected_info = ['~video']
 

test/formats/test_midi.py

@@ -32,7 +32,8 @@ class MIDITest(CommonTests.SimpleFormatsTestCase):
     testfile = 'test.mid'
     expected_info = {
         'length': 127997,
-        '~format': 'Standard MIDI File'
+        '~format': 'Standard MIDI File',
+        '~filesize': '8444',
     }
     unexpected_info = ['~video']
 

test/formats/test_mp4.py

@@ -146,6 +146,7 @@ class M4ATest(CommonMP4Tests.MP4TestCase):
         '~sample_rate': '44100',
         '~bitrate': '14.376',
         '~bits_per_sample': '16',
+        '~filesize': '3591',
     }
     unexpected_info = ['~video']
 
@@ -168,6 +169,7 @@ class M4VTest(CommonMP4Tests.MP4TestCase):
         '~bitrate': '108.043',
         '~bits_per_sample': '16',
         '~video': '1',
+        '~filesize': '5097',
     }
 
 

test/formats/test_vorbis.py

@@ -208,6 +208,7 @@ class FLACTest(CommonVorbisTests.VorbisTestCase):
         '~channels': '2',
         '~sample_rate': '44100',
         '~format': 'FLAC',
+        '~filesize': '6546',
     }
     unexpected_info = ['~video']
 
@@ -301,6 +302,7 @@ class OggVorbisTest(CommonVorbisTests.VorbisTestCase):
         'length': 82,
         '~channels': '2',
         '~sample_rate': '44100',
+        '~filesize': '5221',
     }
 
 
@@ -311,6 +313,7 @@ class OggSpxTest(CommonVorbisTests.VorbisTestCase):
         'length': 89,
         '~channels': '2',
         '~bitrate': '29.6',
+        '~filesize': '608',
     }
     unexpected_info = ['~video']
 
@@ -321,6 +324,7 @@ class OggOpusTest(CommonVorbisTests.VorbisTestCase):
     expected_info = {
         'length': 82,
         '~channels': '2',
+        '~filesize': '1637',
     }
     unexpected_info = ['~video']
 
@@ -340,6 +344,7 @@ class OggTheoraTest(CommonVorbisTests.VorbisTestCase):
         'length': 520,
         '~bitrate': '200.0',
         '~video': '1',
+        '~filesize': '5298',
     }
 
 
@@ -349,6 +354,7 @@ class OggFlacTest(CommonVorbisTests.VorbisTestCase):
     expected_info = {
         'length': 82,
         '~channels': '2',
+        '~filesize': '2573',
     }
     unexpected_info = ['~video']