Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PICARD-2795: display log view verbosity #2346

Merged
merged 2 commits into from
Dec 14, 2023
Merged

PICARD-2795: display log view verbosity #2346

merged 2 commits into from
Dec 14, 2023

Conversation

phw
Copy link
Member

@phw phw commented Dec 13, 2023

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

The log view's verbosity selection just shows the static string "Verbosity" instead of the actually selected level.

Also the level names where not extracted for translation.

Solution

Set the displayed label to the selected level.

grafik

@phw phw requested a review from zas December 13, 2023 22:19
zas
zas approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit 3bab625 into metabrainz:master Dec 14, 2023
59 of 60 checks passed
@phw phw deleted the PICARD-2795-log-view-verbosity branch December 14, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zas zas zas approved these changes

Assignees
No one assigned
Labels
Backport Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phw @zas