Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variables_file.rst #218

Merged
merged 4 commits into from
Jan 20, 2024
Merged

Update variables_file.rst #218

merged 4 commits into from
Jan 20, 2024

Conversation

nullHawk
Copy link
Contributor

Added _filesize variable as mentioned in "metabrainz/picard#2361"

Summary

This is a…

  • Correction
  • Addition
  • Restructuring
  • Minor / simple change (like a typo)
  • Other

Reason for the Change

Added _filesize variable as mentioned in "metabrainz/picard#2361"

Description of the Change

Additional Action Required

Added _filesize variable as mentioned in "metabrainz/picard#2361"
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, units should not be capitalized but if they are named after a proper name (like Celsius). Even if abbreviation is (B for byte, but that's because b is used for bit).

variables/variables_file.rst Outdated Show resolved Hide resolved
variables/variables_file.rst Show resolved Hide resolved
@rdswift
Copy link
Collaborator

rdswift commented Jan 16, 2024

@nullHawk, please also add your name to the list of contributors in about_picard/acknowledgements.rst. Note that the ordering is alphabetical by surname.

nullHawk and others added 2 commits January 16, 2024 21:00
Added blank line before _filesize heading
@nullHawk
Copy link
Contributor Author

AFAIK, units should not be capitalized but if they are named after a proper name (like Celsius). Even if abbreviation is (B for byte, but that's because b is used for bit).

Thank you for mentioning it, I will keep that in mind from now onwards

@nullHawk
Copy link
Contributor Author

@nullHawk, please also add your name to the list of contributors in about_picard/acknowledgements.rst. Note that the ordering is alphabetical by surname.

Ok, got it

added my name "Suryansh Shakya" to the contributor's list
@nullHawk nullHawk requested review from phw and zas January 16, 2024 16:27
@phw phw merged commit 6c4094f into metabrainz:master Jan 20, 2024
1 check passed
@phw
Copy link
Member

phw commented Jan 20, 2024

Thanks again, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants