MBS-13895: Allow Crew United links as otherdbs #3445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a database of audiovisual work, including music videos. They have entries for artists, companies (labels) and videos (recordings). Sadly, we cannot determine the entity type from the URL. All languages seem equivalent, so this standardizes to /en to avoid duplicates.
mwiencek
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-13895
Description
This is a database of audiovisual work, including music videos. They have entries for artists, companies (labels) and videos (recordings). Sadly, we cannot determine the entity type from the URL. All languages seem equivalent, so this standardizes to
/ento avoid duplicates.Removing the entity name and leaving the numeric ID, tempting as it is, does not work.
Testing
Added some tests checking the language standardization, dropping extra crap, and the usual http/www.