Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental user stats #3115

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Incremental user stats #3115

wants to merge 19 commits into from

Conversation

amCap1712
Copy link
Member

@amCap1712 amCap1712 commented Jan 7, 2025

Builds on #3114 and incrementalizing user stats.

@pep8speaks
Copy link

pep8speaks commented Jan 7, 2025

Hello @amCap1712! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2025-01-22 09:33:17 UTC

@amCap1712 amCap1712 force-pushed the incremental-stats-sitewide branch from 46caca9 to a9a62ce Compare January 7, 2025 20:40
@amCap1712 amCap1712 force-pushed the incremental-stats-user branch 2 times, most recently from 824883d to 9430bc7 Compare January 9, 2025 19:36
Base automatically changed from incremental-stats-sitewide to master January 22, 2025 09:32
@amCap1712 amCap1712 force-pushed the incremental-stats-user branch from e410b85 to da8255a Compare January 22, 2025 09:33
@amCap1712 amCap1712 requested a review from mayhem January 22, 2025 09:33
@amCap1712 amCap1712 marked this pull request as ready for review January 22, 2025 09:33
Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the base classes as discussed in IRC. After that, feel free to merge.

I reviewed this PR, but not really line by line. #justbeinghonest

@MonkeyDo
Copy link
Member

I stopped and re-ran the spark test CI suite, which looked stuck.
It is still stuck after the second try, so I suspect something is actually wrong in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants