Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB-1377: Improve Playlist Page #3100

Merged
merged 17 commits into from
Jan 13, 2025
Merged

LB-1377: Improve Playlist Page #3100

merged 17 commits into from
Jan 13, 2025

Conversation

anshg1214
Copy link
Member

@anshg1214 anshg1214 commented Dec 28, 2024

This PR adds a list view for Playlist page. LB-1377

image

This can be further improved by LB-1214 and LB-1215. I'm working on it, but in a separate followup PR.

@anshg1214 anshg1214 changed the title Improve Playlist Page LB-1377: Improve Playlist Page Jan 1, 2025
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
Some UI suggestions below, but funcionnally speaking it's working perfectly 👌

frontend/css/playlists.less Show resolved Hide resolved
frontend/css/playlists.less Outdated Show resolved Hide resolved
frontend/css/playlists.less Outdated Show resolved Hide resolved
frontend/css/playlists.less Show resolved Hide resolved
frontend/css/playlists.less Show resolved Hide resolved
frontend/css/playlists.less Outdated Show resolved Hide resolved
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!
Last little change and it's ready to merge.

frontend/js/src/user/playlists/Playlists.tsx Outdated Show resolved Hide resolved
frontend/js/src/user/playlists/Playlists.tsx Outdated Show resolved Hide resolved
@MonkeyDo
Copy link
Member

Actually, I do have another piece of feedback:

In list view, when I navigate to page 2 the numbering starts back from 1 instead of —in this case— 26:
image

@anshg1214 anshg1214 requested a review from MonkeyDo January 13, 2025 17:34
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yussss, thanks !

@MonkeyDo MonkeyDo merged commit c67be5d into master Jan 13, 2025
3 checks passed
@MonkeyDo MonkeyDo deleted the ansh/improve-playlist-page branch January 13, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants