feat: Made the player screen background dynamic #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07jasjeet
requested changes
Jan 5, 2025
...src/main/java/org/listenbrainz/android/ui/screens/brainzplayer/BrainzPlayerBackDropScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/viewmodel/BrainzPlayerViewModel.kt
Outdated
Show resolved
Hide resolved
1. Add fallback swatches 2. Better animation for background
|
Hi @GautamCoder4019k, Thanks for changes. I took some liberty to improve the feature and fix a few bugs here and there. You can go through this commit for what has been changed. Overall this looks like a nice addition. |
07jasjeet
approved these changes
Jan 11, 2025
|
Hi @07jasjeet , Thanks for improving the commit, I learned some valuable approaches from your changes that I’ll use going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the appearance and functionality of the BrainzPlayer UI by introducing dynamic background colors and enhancing the TopBar component. The most important changes include adding dynamic background color functionality to the player screen, updating the TopBar to accept a customizable background color, and integrating the BrainzPlayerViewModel to manage these changes.
Dynamic Background Color Functionality:
AlbumArtViewPagerto use the dynamic background color.TopBar Customization:
backgroundColorparameter to theTopBarcomponent to allow customizable background colors.ViewModel Integration:
BrainzPlayerViewModelto compute and store the dominant color from the album art. This color is then used as the dynamic background color for the player screen.MainActivity Updates:
*Integrated
BrainzPlayerViewModelto manage the dynamic background color and updated theScaffoldinMainActivityto use this color.These changes collectively enhance the user experience by providing a visually dynamic and customizable interface for the BrainzPlayer.
Screenshots