Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOBILE-209: Handle mini music player like spotify #511

Merged
merged 13 commits into from
Dec 27, 2024

Conversation

Shreyassp002
Copy link
Contributor

@Shreyassp002 Shreyassp002 commented Dec 24, 2024

This pull request introduces the following changes to enhance the mini music player:

  • Persistent Mini Player: The mini music player remains visible even when the song is paused.
  • Dynamic Background: Background color now adapts to the poster using the Palette library.
  • Custom Seekbar: Implemented a custom seekbar for better user experience.
  • Dependency Update: Added the Palette library for dynamic color extraction.

Screenshots-

Screenshot 1 Screenshot 2

Issue Link: MOBILE-209

Let me know if any changes are required :)

@Shreyassp002 Shreyassp002 changed the title Feat: Keep mini music player visible when a song is paused Feat: Handle mini music player like spotify Dec 25, 2024
@Shreyassp002 Shreyassp002 marked this pull request as ready for review December 25, 2024 19:34
@07jasjeet
Copy link
Collaborator

Really exciting PR @Shreyassp002. Can you also fix the seek bar inside of the player screen as well while you're at it? I'm very pleased with your implementation!

@Shreyassp002
Copy link
Contributor Author

@07jasjeet Thanks! I’m on it and will fix the seek bar.

@Shreyassp002
Copy link
Contributor Author

@07jasjeet Fixed seekbar for PlayerScreen

photo_2024-12-27_19-59-31

Copy link
Collaborator

@07jasjeet 07jasjeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great work!

@07jasjeet 07jasjeet merged commit 82838d4 into metabrainz:main Dec 27, 2024
1 check passed
@07jasjeet
Copy link
Collaborator

Thanks for the contribution @Shreyassp002!

@07jasjeet 07jasjeet changed the title Feat: Handle mini music player like spotify MOBILE-209: Handle mini music player like spotify Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants