Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOBILE-210: Fixed stats chart label & heading colors not displaying correctly on Stats screen #510

Merged

Conversation

harsh-bhadauria
Copy link
Contributor

Overview

The following changes have been made in this PR:

  1. Changed the chart label color to be black irrespective of theme (was previously displayed as white on an off white background, leading to low contrast)
  2. Fixed the color of "Listening Activity" and "Top..." text composables
  3. Also added some padding between the axes and the chart background
  4. Fixed a minor typo ("Tast Week" to "Last Week")

Please let me know if any further changes are required.

Screenshots

Issue Screenshots

Fixed Screenshots


Issue on tracker board: MOBILE-210

the color of label on both axes not is black irrespective of theme (+fixed typo)
@07jasjeet 07jasjeet changed the title Fixed stats chart label & heading colors not displaying correctly on Stats screen MOBILE-210: Fixed stats chart label & heading colors not displaying correctly on Stats screen Dec 27, 2024
@07jasjeet
Copy link
Collaborator

07jasjeet commented Dec 27, 2024

Hi @harsh-bhadauria, this was a much needed change. While we are at it, can we remove background of the graph and adjust its color accordingly?

@07jasjeet
Copy link
Collaborator

07jasjeet commented Dec 27, 2024

Hi @harsh-bhadauria! Thanks for this picking up and solving this long standing issue. Everything LGTM.

@07jasjeet 07jasjeet merged commit d1e5761 into metabrainz:main Dec 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants