MOBILE-208: Fix artist screen UI #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed lagging screen by using lazy row instead of row with vertical scroll
hemang-mishra
changed the title
|
Hi, thanks for opening the PR. Its a big one, so will take some time :) |
07jasjeet
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Thanks for the PR @hemang-mishra! This is a huge improvement to what we have currently on the app. LGTM overall, great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
AlbumsCardcomposable.Surfaceto make rounded corner shape visible, changed some padding.BioTagfor the tags, because same UI code was written twice for album tags and artist tags.Rowof Link section scrollable to fix the Edit button issue.AlbumsCard.Please let me know if any changes are required.
Screenshots
Before:
After:
Issue: Link