Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clappy clippy #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Clappy clippy #47

wants to merge 3 commits into from

Conversation

hellow554
Copy link
Contributor

Exactly what the title and the three commits say.
Replaced structopt with clap v3 because that has been integrated and fix some clippy lints

@hellow554
Copy link
Contributor Author

hey @kraj

my PR is almost one year old.
Do you have a opinion on this?
Should I rework it? Should I close it?

@kraj
Copy link
Contributor

kraj commented Feb 15, 2023

hey @kraj

my PR is almost one year old. Do you have a opinion on this? Should I rework it? Should I close it?

@hellow554 thats a bit too long I admit :)
Can you rebase and see if this needs any other updates and re-upload

@hellow554
Copy link
Contributor Author

Rebased, ready for review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellow554 @kraj