Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulator does remove canvas from custom web components and after session the canvas is not in the document anymore #55

Open
marwie opened this issue Jan 4, 2024 · 3 comments

Comments

@marwie
Copy link

marwie commented Jan 4, 2024

Hello, currently when ending the XRSession the renderer seems to be broken.

It works as expected on device returning to the original rendering state

20240104-134440_Test_-_Google_Chrome.mp4
@marwie
Copy link
Author

marwie commented Jan 4, 2024

Oh seems to be related to our project

@marwie marwie closed this as completed Jan 4, 2024
@marwie marwie reopened this Jan 4, 2024
@marwie
Copy link
Author

marwie commented Jan 4, 2024

Hi - so it seems the issue is related to the canvas being a child of a shadowRoot container with a custom web component. See the glitch project for reproducting it here: https://zircon-sunset-singer.glitch.me/ (you can exit XR using the ESC key)

Here's the code: https://glitch.com/edit/#!/zircon-sunset-singer?path=index.html

This might even be an issue inside three.js - I will update this issue if I have any more information

I even get 2 canvases that are reparented to the root document when the XR session starts

20240104-151345_three.js_vr_-_dragging_-_Google_Chrome-logo.mp4

and when the session ends the canvas gets removed from the document altogether

20240104-151449_three.js_vr_-_dragging_-_Google_Chrome-logo.mp4

@marwie marwie changed the title Session.end does break rendering Simulator does remove canvas from custom web components Jan 4, 2024
@marwie marwie changed the title Simulator does remove canvas from custom web components Simulator does remove canvas from custom web components and after session the canvas is not in the document anymore Jan 4, 2024
@marwie
Copy link
Author

marwie commented Jan 4, 2024

This doesnt happen when using Quest with Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant