Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: return Future in DavLockSystem #39

Merged
merged 1 commit into from
Jan 16, 2025
Merged

feat: return Future in DavLockSystem #39

merged 1 commit into from
Jan 16, 2025

Conversation

yuntara
Copy link
Contributor

@yuntara yuntara commented Jan 15, 2025

No description provided.

@messense
Copy link
Owner

Thanks for the PR, could you elaborate on the use case?

@yuntara
Copy link
Contributor Author

yuntara commented Jan 16, 2025

Sorry for forgetting the text.
I created this PR because I want to access my DataBase asynchronously using the locking mechanism, but the DavLockSystem trait is synchronous.

However, this would break the existing DavLockSystem interface, so if there is a demand for synchronous access, it might be better to separate it with a feature flag or implement it some other way.

@messense messense merged commit 4f5092c into messense:main Jan 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuntara @messense