Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build objectstorage-controller image #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: build objectstorage-controller image #14

wants to merge 3 commits into from

Conversation

dkoshkin
Copy link

@dkoshkin dkoshkin commented Jan 22, 2025 •
edited
Loading

Add support to rebuild https://console.cloud.google.com/gcr/images/k8s-staging-sig-storage/global/objectstorage-controller as the registry is being shutdown.

The upstream source image is a manifest so I've added support to build multi-platform images and built linux/amd64,linux/arm64.

dkoshkin added a commit to mesosphere/charts that referenced this pull request Jan 22, 2025
@dkoshkin
fix: use a rebuilt cosi-controller image
04a9b04 
The image was built as part of mesosphere/dkp-container-images#14
dkoshkin added a commit to mesosphere/charts that referenced this pull request Jan 22, 2025
@dkoshkin
fix: use a rebuilt cosi-controller image
03b7a69 
The image was built as part of mesosphere/dkp-container-images#14
@dkoshkin dkoshkin mentioned this pull request Jan 22, 2025
Merged
6 tasks
dkoshkin added a commit to mesosphere/charts that referenced this pull request Jan 22, 2025
@dkoshkin
fix: use a rebuilt cosi-controller image
860321d 
The image was built as part of mesosphere/dkp-container-images#14
jimmidyson added a commit to mesosphere/charts that referenced this pull request Jan 23, 2025
@dkoshkin @jimmidyson
fix: use a rebuilt cosi-controller image (#1542)
16d255c 
The image was built as part of mesosphere/dkp-container-images#14

---------

Co-authored-by: Jimmi Dyson <[email protected]>
github-actions bot pushed a commit to mesosphere/charts that referenced this pull request Jan 23, 2025
fix: use a rebuilt cosi-controller image (#1542) The image was built …
8e7965a 
…as part of mesosphere/dkp-container-images#14  ---------  Co-authored-by: Jimmi Dyson <[email protected]>
jimmidyson
jimmidyson requested changes Jan 23, 2025
View reviewed changes
Copy link

@jimmidyson jimmidyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just do a crane copy? We're not building from source or anything.

@takirala
Copy link
Contributor

We need to do same thing for sidecar as well - https://console.cloud.google.com/gcr/images/k8s-staging-sig-storage/global/objectstorage-sidecar@sha256:3987aa001794851fef72c9e41e715ae803ee20905658e166a6f104d2da4d677f/details

@dkoshkin
Copy link
Author

We need to do same thing for sidecar as well - https://console.cloud.google.com/gcr/images/k8s-staging-sig-storage/global/objectstorage-sidecar@sha256:3987aa001794851fef72c9e41e715ae803ee20905658e166a6f104d2da4d677f/details

@takirala I don't think we do. I don't see objectstorage-sidecar being used anywhere.

@takirala
Copy link
Contributor

We need to do same thing for sidecar as well - console.cloud.google.com/gcr/images/k8s-staging-sig-storage/global/objectstorage-sidecar@sha256:3987aa001794851fef72c9e41e715ae803ee20905658e166a6f104d2da4d677f/details

@takirala I don't think we do. I don't see objectstorage-sidecar being used anywhere.

Its used by ceph and nutanix drivers - https://github.com/mesosphere/kommander-applications/blob/main/licenses.d2iq.yaml#L600-L604

@dkoshkin
Copy link
Author

Yep you're right, just found that too.

@dkoshkin dkoshkin force-pushed the dkoshkin/feat-objectstorage-controller-image branch from d0aa85b to 3b0c4dd Compare January 23, 2025 19:49
@dkoshkin
Copy link
Author

Built the following images:

@dkoshkin
Copy link
Author

Can't we just do a crane copy? We're not building from source or anything.

@jimmidyson if its ok I would like to keep it as is for now as this is (hopefully) temporary. This repo is not setup to use crane.

takirala added a commit to takirala/charts that referenced this pull request Jan 23, 2025
@takirala
fix: use a rebuilt cosi-controller image (mesosphere#1542) The image …
eab71a7 
…was built as part of mesosphere/dkp-container-images#14  ---------  Co-authored-by: Jimmi Dyson <[email protected]>
takirala added a commit to takirala/charts that referenced this pull request Jan 23, 2025
@takirala
fix: use a rebuilt cosi-controller image (mesosphere#1542) The image …
8fa15ea 
…was built as part of mesosphere/dkp-container-images#14  ---------  Co-authored-by: Jimmi Dyson <[email protected]>
takirala added a commit to takirala/charts that referenced this pull request Jan 23, 2025
@takirala
fix: use a rebuilt cosi-controller image (mesosphere#1542) The image …
3c63a36 
…was built as part of mesosphere/dkp-container-images#14  ---------  Co-authored-by: Jimmi Dyson <[email protected]>
takirala added a commit to takirala/charts that referenced this pull request Jan 23, 2025
@takirala
fix: use a rebuilt cosi-controller image (mesosphere#1542) The image …
8089c2e 
…was built as part of mesosphere/dkp-container-images#14  ---------  Co-authored-by: Jimmi Dyson <[email protected]>
@dkoshkin dkoshkin requested a review from jimmidyson January 24, 2025 01:06
takirala added a commit to takirala/charts that referenced this pull request Jan 24, 2025
@takirala
fix: use a rebuilt cosi-controller image (mesosphere#1542) The image …
22a2335 
…was built as part of mesosphere/dkp-container-images#14  ---------  Co-authored-by: Jimmi Dyson <[email protected]>
@takirala
Copy link
Contributor

takirala commented Jan 24, 2025 •
edited
Loading

These images might be available upstream soon (no need to block this PR, just sharing for context):

Estimating pessimistically, I hope we can have this by Feb 7.

https://kubernetes.slack.com/archives/C017EGC1C6N/p1737741962994739?thread_ts=1735283553.436779&cid=C017EGC1C6N

takirala
takirala reviewed Jan 24, 2025
View reviewed changes
cosi/objectstorage-sidecar/README.md
@@ -0,0 +1,11 @@
# objectstorage-controller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# objectstorage-controller
# objectstorage-sidecar

@takirala takirala mentioned this pull request Jan 24, 2025
Open
2 tasks
takirala added a commit to takirala/charts that referenced this pull request Jan 25, 2025
@takirala
fix: use a rebuilt cosi-controller image (mesosphere#1542) The image …
80e9871 
…was built as part of mesosphere/dkp-container-images#14  ---------  Co-authored-by: Jimmi Dyson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takirala takirala takirala approved these changes

@mhrabovcin mhrabovcin mhrabovcin approved these changes

@jimmidyson jimmidyson Awaiting requested review from jimmidyson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkoshkin @takirala @mhrabovcin @jimmidyson