[pull] master from RustCrypto:master #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
try_new creates BlockBuffer or returns an error.
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.43 to 1.0.47. - [Release notes](https://github.com/dtolnay/proc-macro2/releases) - [Commits](dtolnay/proc-macro2@1.0.43...1.0.47) --- updated-dependencies: - dependency-name: proc-macro2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
These releases misspecified their version requirement for `synstructure` and are not compatible with releases prior to v0.12.2. This breaks `-Z minimal-versions` builds for downstream dependencies. See dalek-cryptography/ed25519-dalek#219
Bumps [typenum](https://github.com/paholg/typenum) from 1.15.0 to 1.16.0. - [Release notes](https://github.com/paholg/typenum/releases) - [Changelog](https://github.com/paholg/typenum/blob/main/CHANGELOG.md) - [Commits](paholg/typenum@v1.15.0...v1.16.0) --- updated-dependencies: - dependency-name: typenum dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There are currently build failures on `master` for `cpufeatures` and `zeroize`, which test on macOS runners: https://github.com/RustCrypto/utils/actions/runs/3733690805/jobs/6594187401#step:6:13 = note: ld: in /Users/runner/.rustup/toolchains/1.40.0-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libgetopts-1988d9ef7be544ff.rlib(rust.metadata.bin), archive member 'rust.metadata.bin' with length 198423 is not mach-o or llvm bitcode file '/Users/runner/.rustup/toolchains/1.40.0-x86_64-apple-darwin/lib/rustlib/x86_64-apple-darwin/lib/libgetopts-1988d9ef7be544ff.rlib' It seems these older rustc versions do not support linking with the latest macOS compilers. The build on `stable` works, so we can continue to test macOS, just not that these two crates are MSRV compatible on macOS.
Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.49 to 1.0.50. - [Release notes](https://github.com/dtolnay/proc-macro2/releases) - [Commits](dtolnay/proc-macro2@1.0.49...1.0.50) --- updated-dependencies: - dependency-name: proc-macro2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Replaces the existing API with a `Cmov` trait which is impl'd for all of the unsigned integer types. On x86 platforms this adds support for using both EAX and RAX register operands. On aarch64 platforms it adds support for using both W0 and X0 register operands. Support for `u8` is impl'd generically via upcasting, and support for `u128` is impl'd generically by splitting the value into two `u64`s and doing two selections. Platform-by-platform support is now split into `aarch64`, `x86`, and `portable` backend modules.
The link to the utils repo should be angle-bracketed to make the rustdoc linter happy.
This hopefully allows the docs to generate on docs.rs. Closes #1106
Removes the previous low-level unsafe API and wraps it up instead in a safe API which automatically performs runtime CPU feature detection and RAII guards for enabling DIT and restoring its previous state when done.
This is more inlining-friendly
Initial release
This PR also bumps MSRV to 1.81 for `block-buffer`, `block-padding`, `dbl`, and `inout`, following the MSRV bump in `hybrid-array`.
Dependency on `crypto-common` causes some annoyances as mentioned in RustCrypto/traits#1662. Instead of using the sealed `BlockSizes` trait, the new code uses monomorphization errors to enforce block size correctness. This is somewhat non-idiomatic, but should be fine in practice since block buffers are usually used with fixed block sizes. After this change `BlockSizes` probably can be removed from `crypto-common`. I decided against vendoring `block-buffer` code into `digest` as was proposed in the linked issue because `block-buffer` has third-party users and having a separate crate should make it a bit easier for reviewers.
Removes manual rustdoc feature annotations and performs them automatically
We need to instruct it to build with the `block-padding` feature to ensure that's properly documented. This commit re-adds `all-features = true`
Cuts new `-rc.*` releases of the following: - `block-buffer` v0.11.0-rc.3 - `block-padding` v0.4.0-rc.2 - `dbl` v0.4.0-rc.1 - `inout` v0.2.0-rc.2 These all depend on `hybrid-array` v0.2 (final)
Compiling the crate on non-AArch64 targets results in a compilation error, so having it in workspace can be problematic on other target arches.
The check was too conservative and caused false negatives on some targets. This change follows the `is_x86_feature_detected!` macro (see: https://docs.rs/crate/std_detect/latest/source/src/detect/os/x86.rs).
Without committed Cargo.lock CI fails for this crate because `libc` v0.2.164 and later require Rust 1.63, while MSRV for `aarch64-dit` is set to 1.61.
Previously we were using an empty string for `target_os` to indicate freestanding targets which is incorrect. We should use `none` instead.
On AArch64, we link the `libc` crate to provide access to system call wrappers which can query available CPU features from the kernel, since those calls are protected on that CPU architecture. We don't need `std` though, and it seems we're inadvertently linking it on Linux, Android, and macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )