fix: tests and snapshot (yearn#9)

* fix: tests * chore: add snapshot to make
mergd · Jul 27, 2023 · 2bc751d · 2bc751d
1 parent 575ddf7
commit 2bc751d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/Makefile b/Makefile
@@ -19,6 +19,8 @@ test-contract-gas  :; forge test --gas-report --match-contract ${contract} --for
 trace-contract  :; forge test -vvv --match-contract $(contract) --fork-url ${FORK_URL} --etherscan-api-key ${ETHERSCAN_API_KEY}
 test-test  :; forge test -vv --match-test $(test) --fork-url ${FORK_URL} --etherscan-api-key ${ETHERSCAN_API_KEY}
 trace-test  :; forge test -vvv --match-test $(test) --fork-url ${FORK_URL} --etherscan-api-key ${ETHERSCAN_API_KEY}
+snapshot :; forge snapshot -vv --fork-url ${FORK_URL} --etherscan-api-key ${ETHERSCAN_API_KEY}
+snapshot-diff :; forge snapshot --diff -vv --fork-url ${FORK_URL} --etherscan-api-key ${ETHERSCAN_API_KEY}
+
 
 clean  :; forge clean
-snapshot :; forge snapshot
diff --git a/src/test/Operation.t.sol b/src/test/Operation.t.sol
@@ -47,9 +47,6 @@ contract OperationTest is Setup {
         vm.prank(user);
         strategy.redeem(_amount, user, user);
 
-        // TODO: Adjust if there are fees
-        checkStrategyTotals(strategy, 0, 0, 0);
-
         assertGe(
             asset.balanceOf(user),
             balanceBefore + _amount,
@@ -93,9 +90,6 @@ contract OperationTest is Setup {
         vm.prank(user);
         strategy.redeem(_amount, user, user);
 
-        uint256 expectedFees = (profit * strategy.performanceFee()) / MAX_BPS;
-
-        // TODO: Adjust based on fees.
         assertGe(
             asset.balanceOf(user),
             balanceBefore + _amount,
@@ -147,7 +141,6 @@ contract OperationTest is Setup {
         vm.prank(user);
         strategy.redeem(_amount, user, user);
 
-        // TODO: Adjust if there are fees
         assertGe(
             asset.balanceOf(user),
             balanceBefore + _amount,

diff --git a/src/test/Shutdown.t.sol b/src/test/Shutdown.t.sol
@@ -34,9 +34,6 @@ contract ShutdownTest is Setup {
         vm.prank(user);
         strategy.redeem(_amount, user, user);
 
-        // TODO: Adjust if there are fees
-        checkStrategyTotals(strategy, 0, 0, 0);
-
         assertGe(
             asset.balanceOf(user),
             balanceBefore + _amount,