Update Aho-Corasick #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Build the trie strictly. This has an up front cost, but saves time later when matching. - Force the result early in the alter function in insertTAC. Improves construction times a bit. - Replace the ACLink type with Maybe (ACNode a). This lets us use the value from IM.lookup directly, and simplifies the code. Doesn't seem to have an observable effect on benchmarks. - Update the NFData instances to not rnf outs. It was there since random benchmarks are unlikely to hit O(n^2), but we can do without it. - Use ByteString instead of ByteString.Char8. Char doesn't give use anything here. - Update complexities to be more accurate. - Other small implementation changes.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
Soumik Sarkar: Update Aho-Corasick (#66) - Build the trie strictly. This has an up front cost, but saves time later when matching. - Force the result early in the alter function in insertTAC. Improves construction times a bit. - Replace the ACLink type with Maybe (ACNode a). This lets us use the value from IM.lookup directly, and simplifies the code. Doesn't seem to have an observable effect on benchmarks. - Update the NFData instances to not rnf outs. It was there since random benchmarks are unlikely to hit O(n^2), but we can do without it. - Use ByteString instead of ByteString.Char8. Char doesn't give use anything here. - Update complexities to be more accurate. - Other small implementation changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary change is constructing strictly.
Got hacked on CSES with a large case. The new solution (includes I/O and overhead of other parts of the solution, mind you) takes ~65% of the previous solution's time on this case. But it is also slower in other cases, where being lazy is better.