Refactor: Decompose swap form #200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Andrew718PLTS
requested changes
Feb 28, 2025
|
@chapati23 The 'Continue' button is disabled upon entering the swap-in amount; I can't actually do a swap with that. It looks like the bug that I fixed already. Have you updated the main branch before checkout? If not, try to do a rebase first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While trying to debug, I got very annoyed with the unwieldiness of the SwapForm with lots of components and hooks inlined in the same file.
This PR is about decomposing the SwapForm into smaller parts. It extracts components and hooks into individual files and aims at making the DX for this feature better.
Other changes
I also upgraded yarn from 3.3.1 to 4.6.0 while I was at it, hence the
yarn.lockupdate, but no dependencies where actually changed or updated.Tested
I checked that swaps still work in both directions and with or without approvals.
How to review
Everything should work exactly as it does on production right now, no functionality should have changed.